SAP_ABAP_CODE REVIEW CHECKLIST_FUNCTION MODULE

1. Check List

1.1 Function Group

A. Function Group Should Contain only the Related Function Modules. At runtime, all function modules belonging to a function group are loaded with the calling program. As a result, you should plan carefully which functions really belong in a group and which do not. Otherwise, calling your function modules will unnecessarily increase the amount of memory required by the user.

B. All the Function Modules of a Function Group Should be Activated

1.2 Function Module

A. Global Variable of Function Group Should not Re-Defined in Function Module

B. In Remote Function Modules, Import/Export Parameters must be Defined as Pass by Value

C. Specify parameter by Reference only when you want the Parameter to be Called by Reference Instead of by Value . Tables are always passed by reference.

D. Do Not Declare Export and Import Parameters in the Source Code of the Function Module. The initial code should be generated from the interface definition of the function module.

E. Exceptions must be explicitly triggered to Avoid Dumps in Calling Programs.There are two ABAP Statements that may only be used in Function Modules that you can use to Trigger Exceptions: Syntax RAISE . MESSAGE….. RAISING .

F. “Extended Check done ?

G. Code Inspector check done?