SAP_ABAP_CODE REVIEW CHECKLIST_MODULE POOL

1. Check List

Objects

1.1. Program Description

A. Program Description Adequate:

1.2. Naming Convention Correct

A. Program Name:

B. Development Class:

1.3. Modification Change Management

A. Change History:

B. Begin of Modification Line Included:

C. End of Modification Line Included:

D. Inserted Line History:

E. Commented Line History:

1.4. Documentation

A. Documentation Complete

1.5. Screen Design

1.5.1 Input Fields

A. Checkboxes/Radio-buttons are left aligned with reference text to the right

B. Input/Output fields are left aligned with reference text to the left

C. Group Boxes/Sub-screens/Table Control have a heading

D. Important/Mandatory fields are placed at the top half of the screen

E. Proper Grouping of similar fields or elements

F. All elements are properly spaced out and aligned to fit into the screen. Scrolling is avoided ,if possible. Columns are even spaced out in Table control to fit into the screen

G. Tree Structure and split screen provided wherever required

H. For Important fields, appropriate descriptions retrieved from database and displayed as text next to it for greater clarity

1.5.2 Screen Sequencing and Sub-screens

A. Menus are clearly defined on every screen

B. Proper Sequence of screens is maintained as per the data flow

C. Sub-screens used wherever appropriate and table control properly resized if used inside a sub-screen for minimum scrolling

D. Displays only data that are essential for a task in hand in a work area? Additional information available on request or on separate screen i.e All data is not confined to a single screen.

1.5.3 Functionality/User Friendly/User Interactive

A. Pushbuttons are appropriately used to make the screen as interactive as possible

B. Scrolling Options like Page-Up/Page-Down provided on every screen

C. Help Request and Value Request provided wherever necessary

D. General clipboard functions like Cut,Copy,Paste are placed on Standard Toolbar of each screen

E. Screen Validations and error messages provided wherever necessary

F. Allow user to address screens variably? Option to move forwards and backwards provided?

G. Functions keys attached wherever required

1.6. Menu painter

A. Only required no. of exit options from screen be included

B. Appropriate links to other transactions to be included as user-commands in the Menu Bar, eg. ‘Display Master data’

C. Title bars to be used appropriately, specially in multiple screens or multiple list levels in reports

1.7. Coding Conventions

A. Name assigned to every screen in the OK_CODE field?ie OK_CODE is not directly used in coding

1.8.Transaction Code

A. Transaction Code Assigned To module Pool

1.9 General

A. “Extended Check done ?

B. Code Inspector check done?